Feature/ Consoles - Extract console tabs into components #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emily-grabowski
approved these changes
Dec 20, 2024
enrubio
reviewed
Jan 2, 2025
Comment on lines
+72
to
+74
| <ConsoleTabs | ||
| defaultActiveTabId="overview" | ||
| tabs={[ |
There was a problem hiding this comment.
The AC and Reviewer console have updateActiveTabId={setActiveTabId} set, do we not need this for the other consoles?
Comment on lines
+15
to
+19
| if (!validTabIds.includes(activeTabId)) { | ||
| setActiveTabId(defaultActiveTabId) | ||
| updateActiveTabId?.(`#${defaultActiveTabId}`) | ||
| return | ||
| } |
There was a problem hiding this comment.
Do we need to call updateActiveTabId here? I think when setActiveTabId is called it will trigger useEffect again with a valid (default) tab, so the parent's state would already get updated in line 20 with the default. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr should consolidate the tabs and active tab logic to a separate component so that related logic are not duplicated in all consoles and can be better tested